CCD-6626 CCD is retaining value even after user has manually removed it from UI#2840
CCD-6626 CCD is retaining value even after user has manually removed it from UI#2840markdathornehmcts wants to merge 4 commits intomasterfrom
Conversation
| @@ -76,12 +75,24 @@ public CaseDetails createNewCaseDetails(String caseTypeId, String jurisdictionId | |||
| * @return <code>Optional<CaseDetails></code> - CaseDetails wrapped in Optional | |||
| */ | |||
| public CaseDetails populateCurrentCaseDetailsWithEventFields(CaseDataContent content, CaseDetails caseDetails) { | |||
There was a problem hiding this comment.
Changes look OK, but I'm not sure how SSCS invokes this method. I think it might be via the CaseDataValidatorController or CaseDetailsEndpoint endpoints, but I can't identify route. It might be something from XUI.
I would suggest renaming the method it's now populating with whatever is returned by getData() as well as getEventData(), but only do this if the change fixes the issue. Try it out as a proof of concept first.
paulridout
left a comment
paulridout
left a comment
There was a problem hiding this comment.
Changes look OK, but would recommend trying it out as a proof of concept first.
padmapriyanalam
left a comment
padmapriyanalam
left a comment
There was a problem hiding this comment.
change looks ok. I agree with Paul. Could this be tested in a lower environment first to ensure that the change fixes the issue?
3 participants
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CCD-6626
Change description
CCD is retaining values on Check Your Answers which were removed by the user on a page.
Does this PR introduce a breaking change? (check one with "x")